-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow private transaction receipts to bail out before transaction acceptance #2280
feat: allow private transaction receipts to bail out before transaction acceptance #2280
Conversation
…confirmations that won't show
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this review, I am thinking we really need the promise-based receipt functionality (As much as we can in the 0.8 range and for 0.9 make it a lot more usable with any breaking changes necessary).
…e-transaction-timeout
…transactions, but an early partial receipt to be returned if they time out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented out code left over?
What I did
Made it so private transactions won't time out awaiting confirmations that will never show.
fixes: ApeWorX/ape-alchemy#82
Fixes: APE-1805
How I did it
In the provider method for getting a receipt, moved around the logic to pass through transaction info to receipt data earlier so that private transactions can early return a partial receipt.
How to verify it
Add the
private=True
kwarg toprovider.get_receipt()
Checklist