refactor: split up ape.types modules
#2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwise-constructs
previously approved these changes
Oct 23, 2024
antazoey
force-pushed
the
refactor/split-up-types
branch
from
1685f94
to
08a11d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
splits up
ape.typesso you can import what-you-need faster at times.needed for https://github.com/ApeWorX/ape/pull/2333/files#diff-cc0db0562414127f60137f02bf5994e135314bef3002ca7422972200134418c0
importing from specific modules and having those be small increases performance of modules that only need those.
i still expect users to import from the root init files tho
performance gains hard to realize w/o the rest of it, just making the bigger PR smaller, as this was a needed part for kicking the bottleneck down the road
How I did it
How to verify it
Checklist