perf: hardcoded trusted plugin during --help
check
#2347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
when you have a trusted plugin installed, even if that plugin is also optimized like we did for the ones with core, it is still has a small slowdown because of the trusted check, which makes 1 request to GitHub during
--help
this PR hardcoded the trusted plugin to avoid the request altogether.
How I did it
hardcode the trusted plugin
How to verify it
first install ape-tokens==0.8.1 (to get the full benefit, will still work on 0.8.0)
then
Before i was seeing like 2.23 seconds..
Now I am seeing like 2 seconds
Checklist