perf: Enable flake8 type checks #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
perf/flake-type-only-imports
branch
2 times, most recently
from
e301fdf
to
84508ed
Compare
bitwise-constructs
previously approved these changes
Oct 29, 2024
fubuloubu
previously approved these changes
Oct 29, 2024
antazoey
force-pushed
the
perf/flake-type-only-imports
branch
from
733851e
to
6a860fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implement this https://github.com/snok/flake8-type-checking
in the ways that make the most sense for us.
I only had 1 issue that couldn't be resolved with config: snok/flake8-type-checking#191
Will fix and make #2351 better / easier (post conflict resolution)
How I did it
How to verify it
Checklist