fix: Could not start a Geth process with only WS or IPC #2377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Connecting to an already running IPC process or WS-only geth was working great.
However, I could not start one from the beginning this way...
How I did it
Adjust the implementation geth dev process class to handle more connecton inputs, this is the class that actually manages the process when starting it in the
ape-node
plugin, not the SubprocessProvider class fromape-ethereum
, this one comes from thepy-geth
package.How to verify it
WITHOUT ALREADY HAVING IT RUNNING:
Comment out the URI types not being used and ensure it works.
More to test and such, opening PR early...
Checklist