feat!: Lazy AST and access to root AST model #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Jan 19, 2024
|
|
||
| # The dumped model MUST be the same as the raw data! | ||
| # NOTE: Must happen AFTER the classification step above. | ||
| dumped_model = node.model_dump(mode="json", by_alias=True) |
There was a problem hiding this comment.
when integrating with slither , dump as JSON using aliases and the model should be exactly the same as the compiler output now
antazoey
changed the title
fubuloubu
previously approved these changes
Jan 19, 2024
fubuloubu
previously approved these changes
Mar 20, 2024
fubuloubu
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ast parsing is lazy now by utilizing root model
as a bonus, allows the raw compiler output to be accessible
fixes: ApeWorX/ape#1590
How I did it
use root model
make everything a property or lazy evaluated
How to verify it
things still work but are a bit faster
Checklist