fix: pip cache key would be empty and couldn't use naked versions [APE-1179] #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #24
Fixes: APE-1179
ape-version-pin
. This was quite problematic and explains some anomalies we have seen. Basically, the cache key was justpip-38-
and if you updated Ape, it would not care and would use the Ape from the cache.To fix this, now, if you exclude
ape-version-pin
, we will lookup the latest version from pypi and use that rather than an emptypip install
command. This way, we can properly cache the version ahead of time as well as check for the existence of the key. Now, when an Ape is released in between when a PR is first opened and when subsequent pushes to the PR's branch are done, it will update and use the newer Ape.feat: Allows for setting versions without constraints. Before, if you tried to use
0.6.12
as theape-version-pin
value, it would error because it was expecting something like==0.6.12
. That is not always obvious. It is nice that we support that but it is weird to not allow naked versions as well. So this PR allows setting versions normally.test: add test matrices for each of the parameter types you can provider for
ape-version-pin
. These tests helped me immensely (TDD).chore: run prettier and add a
.prettierrc
to try and match the existing style