Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with default plugins version variable when versions in config [APE-1370] #29

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Sep 5, 2023

fixes, with tests too: #26 (comment)

@vany365 vany365 changed the title fix: issue with default plugins version variable when versions in config fix: issue with default plugins version variable when versions in config [APE-1370] Sep 5, 2023
@antazoey antazoey force-pushed the fix/varinterpo branch 5 times, most recently from f14f7f9 to 6afffd6 Compare September 5, 2023 13:26
@antazoey antazoey merged commit 186f2f8 into ApeWorX:main Sep 5, 2023
8 checks passed
@antazoey antazoey deleted the fix/varinterpo branch September 5, 2023 14:55
@antazoey
Copy link
Member Author

antazoey commented Sep 5, 2023

I tested these changes on the snekmate repo (the project that reported the regression) and things passed!
https://github.com/antazoey/snekmate/actions/runs/6085791567/job/16510699465?pr=1

So I am going to do another release, including updating the v2 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants