-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support kafka sql snapshotting #4665
Merged
EricWittmann
merged 13 commits into
Apicurio:main
from
carlesarnal:support-kafka-sql-snapshotting
May 29, 2024
Merged
Support kafka sql snapshotting #4665
EricWittmann
merged 13 commits into
Apicurio:main
from
carlesarnal:support-kafka-sql-snapshotting
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlesarnal
force-pushed
the
support-kafka-sql-snapshotting
branch
3 times, most recently
from
May 10, 2024 09:09
92a71ba
to
3479bc7
Compare
This was
linked to
issues
May 15, 2024
carlesarnal
force-pushed
the
support-kafka-sql-snapshotting
branch
from
May 21, 2024 07:28
332252b
to
28e62a3
Compare
carlesarnal
force-pushed
the
support-kafka-sql-snapshotting
branch
from
May 22, 2024 11:37
4d4475c
to
c6e71d3
Compare
carlesarnal
force-pushed
the
support-kafka-sql-snapshotting
branch
from
May 28, 2024 13:04
ad2d190
to
4ea84ba
Compare
@EricWittmann this is good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces initial support for kafkasql snapshotting.
This follows the below approach:
/admin/config/triggerSnapshot
is made. For KafkaSql, this sends a snapshot marker message with a snapshot id to the journal topic, meaning that, at that point, a snapshot was triggered.One note:
PS: Don't be scared by the 22k lines changed, 22,007 of them are just the snapshot I added for the unit test.