Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to xunit v3 #2440

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update to xunit v3 #2440

wants to merge 1 commit into from

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Jan 10, 2025

  • Update to xunit v3.
  • Avoid infinite loop and throw if test times out.

Resolves #2439.

@martincostello martincostello added CI/build dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 143 out of 158 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • Directory.Packages.props: Language not supported
  • eng/Test.targets: Language not supported
  • src/Snippets/Snippets.csproj: Language not supported
  • test/Polly.Core.Tests/CircuitBreaker/Controller/CircuitStateControllerTests.cs: Evaluated as low risk
  • test/Polly.Core.Tests/CircuitBreaker/BrokenCircuitExceptionTests.cs: Evaluated as low risk
  • test/Polly.Core.Tests/CircuitBreaker/IsolatedCircuitExceptionTests.cs: Evaluated as low risk
  • test/Polly.Core.Tests/Fallback/FallbackHandlerTests.cs: Evaluated as low risk
  • test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResiliencePipelineBuilderTests.cs: Evaluated as low risk
  • test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerOptionsTests.cs: Evaluated as low risk
  • test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResilienceStrategyTests.cs: Evaluated as low risk
  • test/Polly.Core.Tests/Fallback/FallbackResiliencePipelineBuilderExtensionsTests.cs: Evaluated as low risk
  • test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerStateProviderTests.cs: Evaluated as low risk
  • src/Snippets/Docs/Testing.cs: Evaluated as low risk
  • build.cake: Evaluated as low risk
  • test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerPredicateArgumentsTests.cs: Evaluated as low risk
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (f982bb6) to head (43001fd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2440   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         312      312           
  Lines        7464     7464           
  Branches     1121     1121           
=======================================
  Hits         6374     6374           
  Misses        905      905           
  Partials      185      185           
Flag Coverage Δ
linux 85.39% <ø> (ø)
macos 85.39% <ø> (ø)
windows 85.33% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

martincostello added a commit that referenced this pull request Jan 10, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Takes some changes from #2440 which is blocked on support for xunit v3 in Stryker. with the aim of making #2440 a smaller change.

Contributes to #2439.
martincostello added a commit that referenced this pull request Jan 10, 2025
Takes some changes from #2440 which is blocked on support for xunit v3 in Stryker. with the aim of making #2440 a smaller change.

Contributes to #2439.
@martincostello martincostello force-pushed the xunit-v3 branch 2 times, most recently from a0f170d to 0d89f44 Compare January 11, 2025 16:23
Update to xunit v3.

Resolves #2439.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/build dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to xunit v3
1 participant