Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix after call setMinMaxScaleX, when scaleX to bound value, chart will jump #138

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix after call setMinMaxScaleX, when scaleX to bound value, chart will jump #138

merged 1 commit into from
Aug 7, 2023

Conversation

hannesa2
Copy link
Collaborator

@hannesa2 hannesa2 commented Aug 3, 2023

It's a copy of PhilJay#5391

@hannesa2 hannesa2 mentioned this pull request Aug 3, 2023
Open
3 tasks
@hannesa2
Copy link
Collaborator Author

hannesa2 commented Aug 3, 2023

@renzhenfei
This can have a lot of UI impacts, that's why I hesitate to merge it without seeing the before and after affect of this pull request.
I would love to have a UI test for this. So please can you demonstrate anyhow in sample screenshots the improvement ?

@hannesa2 hannesa2 added the enhancement New feature or request label Aug 3, 2023
@hannesa2 hannesa2 changed the title fix after call setMinMaxScaleX, when scaleX to bound value, chart wil… fix after call setMinMaxScaleX, when scaleX to bound value, chart will jump Aug 7, 2023
@hannesa2 hannesa2 merged commit db20125 into master Aug 7, 2023
3 checks passed
@hannesa2 hannesa2 deleted the renzhenfeiMaster branch August 7, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannesa2 @renzhenfei61