Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: opt-in/out redirection and inaccessible page handling #43

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix: opt-in/out redirection and inaccessible page handling #43

merged 2 commits into from
Sep 18, 2024
+357 −365

Conversation

anisAronno
Copy link
Contributor

@anisAronno anisAronno commented Sep 12, 2024 •
edited
Loading

  • Fixed redirection for opt-in/opt-out actions, redirecting to the dashboard for inaccessible pages like update.php or updater.php.
  • Refactored code by separating request validation and capability checks for better readability.
  • Added a method to handle inaccessible pages in one place for easier maintenance.

Issue: https://github.com/Appsero/appsero-api/issues/328

@anisAronno anisAronno force-pushed the feature/fix-optin-or-optout-redirect-page-expiry-issues branch from deaaea3 to 377d64f Compare September 12, 2024 11:49
@anisAronno anisAronno merged commit 0278a00 into develop Sep 18, 2024
1 check passed
@anisAronno anisAronno deleted the feature/fix-optin-or-optout-redirect-page-expiry-issues branch September 18, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdmehedi bdmehedi Awaiting requested review from bdmehedi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anisAronno