Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less verbose box_alphabetical_calls_linter() #119

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

radbasa
Copy link
Collaborator

@radbasa radbasa commented Jul 11, 2024

Issue #118

Description

  • Adds a verbose switch to box_alphabetical_calls_linter().
  • Defaults to FALSE.
  • Updated tests.
  • Reports first unsorted function in box function list.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@radbasa radbasa requested a review from kamilzyla July 11, 2024 06:35
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (1a31217) to head (a744f64).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   97.99%   98.00%           
=======================================
  Files          22       22           
  Lines        1046     1050    +4     
=======================================
+ Hits         1025     1029    +4     
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamilzyla
Copy link
Contributor

kamilzyla commented Jul 11, 2024

Nice, kudos for quick reaction! 🎉

I'd suggest to make this linter less verbose by default and not even provide any switch. I think just pointing to the beginning of the unsorted list is enough; pointing to each element separately is just noise.

Idea: perhaps it would be even better to point to the first out-of-order element of the list. This would be helpful in situations where it is not clear what is the alphabetical order (e.g. due to special characters).

@radbasa
Copy link
Collaborator Author

radbasa commented Jul 12, 2024

That "point to the first out-of-order element of the [function] list" is a great idea.

@radbasa radbasa changed the title Add verbose swithch to box_alphabetical_calls_linter() Less verbose box_alphabetical_calls_linter() Jul 12, 2024
@radbasa radbasa linked an issue Jul 12, 2024 that may be closed by this pull request
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radbasa radbasa merged commit 3a4972a into main Jul 15, 2024
7 checks passed
@radbasa radbasa deleted the less-verbose-alphabetical-linter branch July 15, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Less verbose lint report for box_alphabetical_calls_linter()
3 participants