code review feedback

Apra-Labs · Oct 3, 2024 · 6f90a5d · 6f90a5d
1 parent b4f29a4
commit 6f90a5d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/base/include/Module.h b/base/include/Module.h
@@ -21,6 +21,8 @@
 #include "BufferMaker.h"
 #include "APCallback.h"
 
+#define DUMMY_CTRL_EOP_PIN "dummy_ctrl_eop_pin"
+
 using namespace std;
 
 class FrameContainerQueue;

diff --git a/base/include/SimpleControlModule.h b/base/include/SimpleControlModule.h
@@ -17,8 +17,8 @@ class SimpleControlModule : public AbsControlModule
 	{
 	}
 	std::string printStatus();
-	void handleError(const APErrorObject &error) override;
-    void handleHealthCallback(const APHealthObject &healthObj) override;
+	void handleError(const APErrorObject& error) override;
+	void handleHealthCallback(const APHealthObject& healthObj) override;
 protected:
 	void sendEOS();
 	void sendEOS(frame_sp& frame);

diff --git a/base/src/Module.cpp b/base/src/Module.cpp
@@ -1581,7 +1581,7 @@ bool Module::addEoPFrame(frame_container &frames)
       auto frame = frame_sp(new EoPFrame());
       auto metadata = framemetadata_sp(new FrameMetadata(FrameMetadata::GENERAL));
       frame->setMetadata((metadata));
-      frames.insert(make_pair("dummy_eop_ctrl_pin", frame));
+      frames.insert(make_pair(DUMMY_CTRL_EOP_PIN, frame));
   }
 
   // if sieve is disabled for atleast one connection - send additional EOP