Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Affine transform module - support DMA/CUDA via NPPI and HOST via open cv #227

Merged
merged 57 commits into from
Jul 31, 2023
Merged

Affine transform module - support DMA/CUDA via NPPI and HOST via open cv #227

merged 57 commits into from
Jul 31, 2023

Conversation

venkat0907
Copy link
Contributor

@venkat0907 venkat0907 commented May 4, 2023 •
edited
Loading

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #36

Description
Finished NPPI based affine transform module.
Supports YUV444, *RGB, MONO.
Added tests and data.

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Alternative was to implement in opencv to support CPU - which is yet to be done.

Type

Type Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@github-actions
Copy link

github-actions bot commented May 4, 2023 •
edited
Loading

Test Results Linux

    1 files  ±  0      1 suites  ±0   10m 21s ⏱️ -1s
292 tests +21  224 ✔️ +  5  68 💤 +16  0 ❌ ±0 
224 runs  +  5  156 ✔️  - 11  68 💤 +16  0 ❌ ±0 

Results for commit 1e84736. ± Comparison against base commit c2f230e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 4, 2023 •
edited
Loading

Test Results Linux_ARM64

    1 files  ±  0      1 suites  ±0   11m 0s ⏱️ +3s
406 tests +21  253 ✔️ +  5  153 💤 +16  0 ❌ ±0 
253 runs  +  5  100 ✔️  - 11  153 💤 +16  0 ❌ ±0 

Results for commit 1e84736. ± Comparison against base commit c2f230e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 5, 2023 •
edited
Loading

Test Results Win-nocuda

    1 files  ±  0      1 suites  ±0   10m 46s ⏱️ +5s
288 tests +21  224 ✔️ +  5  64 💤 +16  0 ❌ ±0 
224 runs  +  5  160 ✔️  - 11  64 💤 +16  0 ❌ ±0 

Results for commit 1e84736. ± Comparison against base commit c2f230e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 12, 2023 •
edited
Loading

Test Results Linux-CudaT

    1 files  ±  0      1 suites  ±0   10m 23s ⏱️ -1s
383 tests +21  226 ✔️ +  5  157 💤 +16  0 ❌ ±0 
226 runs  +  5    69 ✔️  - 11  157 💤 +16  0 ❌ ±0 

Results for commit 1e84736. ± Comparison against base commit c2f230e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 16, 2023 •
edited
Loading

Test Results Windows-cuda

    1 files  ±  0      1 suites  ±0   12m 17s ⏱️ -1s
379 tests +21  285 ✔️ +  5  94 💤 +16  0 ❌ ±0 
285 runs  +  5  191 ✔️  - 11  94 💤 +16  0 ❌ ±0 

Results for commit 1e84736. ± Comparison against base commit c2f230e.

♻️ This comment has been updated with latest results.

mraduldubey
mraduldubey requested changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@mraduldubey mraduldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary:

  1. Let us support HOST memory via opencv
  2. Add tests for HOST memory
  3. Add test for dynamic property change
  4. Provide some clarifications/comments on interpolation

base/test/affinetransform_tests.cpp Outdated Show resolved Hide resolved
base/test/affinetransform_tests.cpp Show resolved Hide resolved
base/test/affinetransform_tests.cpp Show resolved Hide resolved
base/test/affinetransform_tests.cpp Show resolved Hide resolved
base/test/affinetransform_tests.cpp Show resolved Hide resolved
base/src/AffineTransform.cpp Outdated Show resolved Hide resolved
base/src/AffineTransform.cpp Outdated Show resolved Hide resolved
base/src/AffineTransform.cpp Show resolved Hide resolved
base/src/AffineTransform.cpp Outdated Show resolved Hide resolved
base/test/affinetransform_tests.cpp Show resolved Hide resolved
@mraduldubey mraduldubey changed the title Affinetransformnppi Affine transform module - support DMA/CUDA via NPPI and HOST via open cv May 23, 2023
mraduldubey
mraduldubey previously approved these changes Jun 15, 2023
View reviewed changes
@venkat0907 venkat0907 force-pushed the AffineTransformNPPI branch 2 times, most recently from 158e47a to 7d1ecda Compare July 17, 2023 05:48
@mraduldubey mraduldubey mentioned this pull request Jul 28, 2023
Closed
2 tasks
@mraduldubey mraduldubey added the enhancement New feature or request label Jul 28, 2023
@kumaakh kumaakh merged commit a70b01f into main Jul 31, 2023
18 of 20 checks passed
@kumaakh kumaakh deleted the AffineTransformNPPI branch July 31, 2023 12:27
@mraduldubey mraduldubey mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraduldubey mraduldubey mraduldubey approved these changes

Assignees

@yashrajsapra yashrajsapra

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Affine Transform Module
4 participants
@venkat0907 @mraduldubey @kumaakh @yashrajsapra