Enhanced playback compatibility: Mp4Writer-generated videos now compatible with all media players #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaakh
force-pushed
the
Mp4WriterVideoPlaybackFix
branch
from
5293fa6
to
24d35e4
Compare
kumaakh
force-pushed
the
Mp4WriterVideoPlaybackFix
branch
from
24d35e4
to
9df9078
Compare
mraduldubey
requested changes
Jul 11, 2023
kumaakh
force-pushed
the
Mp4WriterVideoPlaybackFix
branch
from
9df9078
to
e4cf54a
Compare
mraduldubey
requested changes
Jul 14, 2023
…4WriterVideoPlaybackFix
mraduldubey
requested changes
Jul 14, 2023
mraduldubey
previously approved these changes
Jul 17, 2023
mraduldubey
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Bug fix : Now videos written using Mp4Writer can be played across all media players.
Precise description of the changes in this pull request
The fix was to prepend size of frames at the last two bytes of Nalu saprator and to add the size of sps and pps at last byte of each nalu saperator.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Type Choose one: (Bug fix | Feature | Documentation | Testing | Other)
Screenshots (if applicable)
Checklist