Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArchiveSpaceManager fixes #379

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Vinayak-YB
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[Issue]

Description

There were a few issue in ArchiveSpaceManager - produce, sampling rate logic. These are fixed now.

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type

Type Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

Copy link

github-actions bot commented Aug 1, 2024

Test Results Windows-cuda

  1 files  ±0    1 suites  ±0   12m 7s ⏱️ -1s
408 tests ±0  292 ✅ ±0  116 💤 ±0  0 ❌ ±0 
292 runs  ±0  176 ✅ ±0  116 💤 ±0  0 ❌ ±0 

Results for commit d96c383. ± Comparison against base commit c2c4810.

Copy link

github-actions bot commented Aug 1, 2024

Test Results Linux-CudaT

  1 files  ±0    1 suites  ±0   11m 59s ⏱️ + 1m 43s
413 tests ±0  253 ✅ +4  160 💤  - 3  0 ❌ ±0 
253 runs  +3   93 ✅  - 1  160 💤 +5  0 ❌ ±0 

Results for commit d96c383. ± Comparison against base commit c2c4810.

Copy link

github-actions bot commented Aug 1, 2024

Test Results Linux

  1 files  ±0    1 suites  ±0   10m 13s ⏱️ -1s
312 tests ±0  231 ✅ ±0  81 💤 ±0  0 ❌ ±0 
231 runs  ±0  150 ✅ ±0  81 💤 ±0  0 ❌ ±0 

Results for commit d96c383. ± Comparison against base commit c2c4810.

Copy link

github-actions bot commented Aug 1, 2024

Test Results Win-nocuda

  1 files  ±0    1 suites  ±0   10m 27s ⏱️ -1s
307 tests ±0  231 ✅ ±0  76 💤 ±0  0 ❌ ±0 
231 runs  ±0  155 ✅ ±0  76 💤 ±0  0 ❌ ±0 

Results for commit d96c383. ± Comparison against base commit c2c4810.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant