-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Baresip and libre, revert changes in H264Decoder and NvTransform specific to NVR and fix a memory leak in nvcodec decoder #389
base: main
Are you sure you want to change the base?
Changes from all commits
130ee2d
24df6a3
39c24b6
e451b05
94c9c0f
b9a5ea2
42550e3
65dd52a
debf2b9
405891d
dbbf637
af79ad0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -733,12 +733,10 @@ bool H264Decoder::shouldTriggerSOS() | |
|
||
bool H264Decoder::processEOS(string& pinId) | ||
{ | ||
//THIS HAS BEEN COMMENTED IN NVR - BECAUSE EOS IS SENT FROM MP4READER WHICH COMES TO DECODER AND THE FOLLOWING PROCESS IS NOT REQUIRED IN NVR. | ||
|
||
// auto frame = frame_sp(new EmptyFrame()); | ||
// mDetail->compute(frame->data(), frame->size(), frame->timestamp); | ||
// LOG_ERROR << "processes sos " ; | ||
//mShouldTriggerSOS = true; | ||
auto frame = frame_sp(new EmptyFrame()); | ||
mDetail->compute(frame->data(), frame->size(), frame->timestamp); | ||
LOG_ERROR << "processes sos " ; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is thie log error. |
||
mShouldTriggerSOS = true; | ||
return true; | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,4 +111,6 @@ H264Utils::H264_NAL_TYPE H264Utils::getNalTypeAfterSpsPps(void* frameData, size_ | |
} | ||
} | ||
} | ||
|
||
return typeFound; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,6 @@ bool PipeLine::addControlModule(boost::shared_ptr<AbsControlModule> cModule) | |
for (int i = 0; i < modules.size(); i++) | ||
{ | ||
modules[i]->addControlModule(cModule); | ||
cModule->pipelineModules.push_back(modules[i]); | ||
} | ||
return true; | ||
} | ||
|
@@ -163,6 +162,7 @@ void PipeLine::run_all_threaded() | |
{ | ||
Module& m = *(modules[0]->controlModule); | ||
m.myThread = boost::thread(ref(m)); | ||
Utils::setModuleThreadName(m.myThread, m.getId()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a merge with md/controlmodulepipelineFixes is required There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not reviewing this file |
||
} | ||
mPlay = true; | ||
} | ||
|
@@ -232,6 +232,11 @@ void PipeLine::stop() | |
i->get()->stop(); | ||
} | ||
} | ||
|
||
if ((modules[0]->controlModule) != nullptr) | ||
{ | ||
modules[0]->controlModule->stop(); | ||
} | ||
} | ||
|
||
void PipeLine::wait_for_all(bool ignoreStatus) | ||
|
@@ -242,6 +247,12 @@ void PipeLine::wait_for_all(bool ignoreStatus) | |
return; | ||
} | ||
|
||
if ((modules[0]->controlModule) != nullptr) | ||
{ | ||
Module& m = *(modules[0]->controlModule); | ||
m.myThread.join(); | ||
} | ||
|
||
for (auto i = modules.begin(); i != modules.end(); i++) | ||
{ | ||
Module& m = *(i->get()); | ||
|
@@ -250,25 +261,38 @@ void PipeLine::wait_for_all(bool ignoreStatus) | |
} | ||
|
||
|
||
void PipeLine::interrup_wait_for_all() | ||
void PipeLine::interrupt_wait_for_all() | ||
{ | ||
if (myStatus > PL_STOPPING) | ||
{ | ||
LOG_INFO << "Pipeline status " << getStatus() << " Can not be stopped !"; | ||
return; | ||
} | ||
|
||
if ((modules[0]->controlModule) != nullptr) | ||
{ | ||
Module& m = *(modules[0]->controlModule); | ||
m.myThread.interrupt(); | ||
} | ||
|
||
for (auto i = modules.begin(); i != modules.end(); i++) | ||
{ | ||
Module& m = *(i->get()); | ||
m.myThread.interrupt(); | ||
} | ||
|
||
if ((modules[0]->controlModule) != nullptr) | ||
{ | ||
Module& m = *(modules[0]->controlModule); | ||
m.myThread.join(); | ||
} | ||
|
||
for (auto i = modules.begin(); i != modules.end(); i++) | ||
{ | ||
Module& m = *(i->get()); | ||
m.myThread.join(); | ||
} | ||
|
||
myStatus = PL_STOPPED; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep an option open to build with baresip if required