Zillion: use useful item classification #4179
Conversation
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
| "Champ": 9999, | ||
| "JJ": 9999, | ||
| "Win": 9999, | ||
| "Empty": 0, |
There was a problem hiding this comment.
Why are Empty and Bread included if the default is already 0?
There was a problem hiding this comment.
The values are here so that it's more clear when reading this code what happens with Empty and Bread.
If this "Empty": 0, weren't here, it would take a little more mental energy for the reader to figure out what happens with it.
The default is just a safety in case something changes in the future.
| """ make the item useful if the number in the item pool is below this number """ | ||
|
|
||
|
|
||
| def get_classification(name: str, zz_item: ZzItem, item_counts: Counter[str]) -> IC: |
There was a problem hiding this comment.
I assume this not accounting for extra items such as from start_inventory, item_plando, and item_links is intended / expected?
There was a problem hiding this comment.
I admit I didn't think of those when writing this.
But thinking about it now, I think it's not worth the added complexity for something that won't make very much of a difference.
There was a problem hiding this comment.
I agree that it's not worth changing, especially since this'll only ever make items Useful when they shouldn't be, and not the reverse.
What is this fixing or adding?
Use the
usefulitem classification. (wasn't using any before)How was this tested?
play through a game