forked from CaitSith2/z3randomizer
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add silver Power Star item #9
Open
Kappatechy
wants to merge
5
commits into
ArchipelagoMW:main
Choose a base branch
from
Kappatechy:progression_power_star_basepatch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add silver Power Star item #9
Kappatechy
wants to merge
5
commits into
ArchipelagoMW:main
from
Kappatechy:progression_power_star_basepatch
Commits on Aug 31, 2023
-
This change adds item ID 0x69 (currently unused) which duplicates the data of the existing 0x6B "Goal Item (Multi/Power Star)" and changes the palette of the existing power star item to 0x02 (silver). This is intended to allow differentiating progression items (gold stars) from non-progression items (silver stars) for other worlds. New hash: 7c9599a6ff33563b33178ab8e5a1dac8 Example image: https://i.imgur.com/B2LUdFS.png
Configuration menu - View commit details
-
Copy full SHA for 91c3dd6 - Browse repository at this point
Copy the full SHA 91c3dd6View commit details
Commits on Sep 3, 2023
-
Fix silver power star item get animation
Fix a bug in the previous commit where the silver power star item in newitems.asm:.properties still used the gold power star palette, causing the "item get" animation to incorrectly show a gold power star upon picking up a silver power star. Also updated comments for consistency with gold/silver power star terminology. Tested with a 2-player lttp/hollowknight multiworld verifying standing items look correct in and out of shops and picking up items animates correctly for both gold and silver power stars. The previous commit listed an outdated screenshot (with the colors reversed); the updated screenshot showing this feature is: https://i.imgur.com/iMPxzgw.png New ROM hash after this change: 8719f420b587adac8d3750792d46e5bd
Configuration menu - View commit details
-
Copy full SHA for b787b83 - Browse repository at this point
Copy the full SHA b787b83View commit details
Commits on Feb 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d4e0a9e - Browse repository at this point
Copy the full SHA d4e0a9eView commit details
Commits on Feb 26, 2024
-
Compress code for collection of Power Stars
Adding handling for a new item to the ASM was causing that code it to overflow its banks. The code has been tweaked to fit into its allotted space, while still performing the same function.
Configuration menu - View commit details
-
Copy full SHA for ebe9ea9 - Browse repository at this point
Copy the full SHA ebe9ea9View commit details
Commits on Apr 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c8b20ee - Browse repository at this point
Copy the full SHA c8b20eeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.