Fix cbor parsing bug #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when options were parsed, the corresponding values were not being consumed if they were not one of the recognized strings. Authenticators may provide additional options, in which case the value should be consumed and ignored. Otherwise, an error will be thrown because the decoder encounters a boolean instead of the next integer key of the map. This small patch fixes this bug. Signed-off-by: Peter Engelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when options were parsed, the corresponding values were not
being consumed if they were not one of the recognized strings.
Authenticators may provide additional options, in which case the value
should be consumed and ignored. Otherwise, an error will be thrown
because the decoder encounters a boolean instead of the next integer key
of the map.
This small patch fixes this bug.