Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage check #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix usage check #5

wants to merge 1 commit into from

Commits on Feb 14, 2023

  1. Fix usage check 

    This patch fixes the usage check in the device detection:

- Instead of usage 0x21, we now check for usage 0x01 as mandated by the
  FIDO2 spec, § 11.2.8.1 [0].
- Instead of using the last usage value in the USB descriptor, which
  belongs to an endpoint and not to the device, we now use the first
  (non-zero) value.

The descriptor parsing could still be improved, but this should fix
compatibility with all compliant FIDO2 devices.

[0] https://fidoalliance.org/specs/fido-v2.1-ps-20210615/fido-client-to-authenticator-protocol-v2.1-ps-20210615.html#usb-discovery
    @robin-nitrokey
    robin-nitrokey committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    27d7406 View commit details
    Browse the repository at this point in the history