Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] refactor: transaction filter as a modal for mobile devices #462

Closed
wants to merge 6 commits into from

Conversation

alexbarnsley
Copy link
Member

Summary

https://app.clickup.com/t/863h8wx7b

requires ArkEcosystem/laravel-foundation#590

Created a new Livewire Paginator which serialises the data between requests. This is instead of using a computed property so the data can be updated as and when, though I'm not sure it's necessary since it now uses the wire:target

  • tests?
  • fix loading of table list on open of modal

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley
Copy link
Member Author

Closing to use the JS method instead in #463

@ItsANameToo ItsANameToo deleted the refactor/transaction-filter-as-a-modal branch October 20, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant