fix: navbar offset on modal open #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/arkscan into fix/navbar-offset-on-modal-open
alexbarnsley
requested review from
boldninja,
ItsANameToo and
samharperpittam
as code owners
ItsANameToo
reviewed
Sep 4, 2023
Comment on lines
+7
to
+8
| <x-navbar.desktop :navigation="$navigation" /> | ||
| <x-navbar.mobile :navigation="$navigation" /> |
There was a problem hiding this comment.
what was the reason for needing this?
There was a problem hiding this comment.
Just separated out the components as it was hard to differentiate between the two
samharperpittam
approved these changes
Sep 4, 2023
ItsANameToo
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/862k7ffck
requires ArkEcosystem/laravel-foundation#594
Checklist