-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition for Target Brahma F4 #27936
base: master
Are you sure you want to change the base?
Addition for Target Brahma F4 #27936
Conversation
Adding Target Brahma F4 FC Hardware has been tested with these configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs readme.md in this form https://github.com/ArduPilot/ardupilot/tree/master/libraries/AP_HAL_ChibiOS/hwdef/ZeroOneX6
also bootloader binary...see other hwdefs
Ok will do and update shortly |
add bootloader for brahmaf4
Hi @Hwurzburg files have been updated as requested compiled bootloader as well |
PA9 USART1_TX USART1 | ||
define DEFAULT_SERIAL1_PROTOCOL SerialProtocol_RCIN | ||
|
||
PB10 USART3_TX USART3 NODMA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have esc telem as default instead of telem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't mark as resolved without an actual change or explanation
| :------- | :------- | :------ | :------------------ | | ||
| SERIAL 0 | DM/DP | USB | Mavlink | | ||
| SERIAL 1 | RX1/TX1 | USART 1 | (DMA) (Reciever) | | ||
| SERIAL 2 | RX3/TX3 | USART 3 | (NODMA) (ESC) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is Telem unless you change hwdef and make default ESC Telem....which I suggest you do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is pinned out as ESC telem on the ESC connector, I think not making the protocol ESC telem is a mistake
readme upate uart Co-authored-by: Henry Wurzburg <[email protected]>
msp manual change readme Co-authored-by: Henry Wurzburg <[email protected]>
Co-authored-by: Henry Wurzburg <[email protected]>
remove extra config
ap_notify led update remove commented lines
Better Grouping Documentation Co-authored-by: Henry Wurzburg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all done as requested
| :------- | :------- | :------ | :------------------ | | ||
| SERIAL 0 | DM/DP | USB | Mavlink | | ||
| SERIAL 1 | RX1/TX1 | USART 1 | (DMA) (Reciever) | | ||
| SERIAL 2 | RX3/TX3 | USART 3 | (NODMA) (ESC) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
I still have an issue about esc telem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not understand my request re ESC telem
also need to squash and library split, but I can do that for you if you wish once the last changes are made
@ShadowWalker8642 are you still interested in pursuing this? still needs comment addressed and conflicts resolved... |
Esc telemetry default Co-authored-by: Henry Wurzburg <[email protected]>
Hi really sorry been caught up, I have done the esc telemetry change as requested |
Adding Target Brahma F4 F405
6 uarts,spiflash,osd,
imu bmi270
This Target has passed internal hardware testing.