Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition for Target Brahma F4 #27936

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

ShadowWalker8642
Copy link

Adding Target Brahma F4 F405
6 uarts,spiflash,osd,
imu bmi270
This Target has passed internal hardware testing.

Adding Target Brahma F4 FC Hardware has been tested with these configuration
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs readme.md in this form https://github.com/ArduPilot/ardupilot/tree/master/libraries/AP_HAL_ChibiOS/hwdef/ZeroOneX6
also bootloader binary...see other hwdefs

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Aug 26, 2024
@ShadowWalker8642
Copy link
Author

needs readme.md in this form https://github.com/ArduPilot/ardupilot/tree/master/libraries/AP_HAL_ChibiOS/hwdef/ZeroOneX6 also bootloader binary...see other hwdefs

Ok will do and update shortly

@ShadowWalker8642
Copy link
Author

Hi @Hwurzburg files have been updated as requested compiled bootloader as well

PA9 USART1_TX USART1
define DEFAULT_SERIAL1_PROTOCOL SerialProtocol_RCIN

PB10 USART3_TX USART3 NODMA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have esc telem as default instead of telem

Copy link
Collaborator

@Hwurzburg Hwurzburg Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't mark as resolved without an actual change or explanation

libraries/AP_HAL_ChibiOS/hwdef/BrahmaF4/README.md Outdated Show resolved Hide resolved
| :------- | :------- | :------ | :------------------ |
| SERIAL 0 | DM/DP | USB | Mavlink |
| SERIAL 1 | RX1/TX1 | USART 1 | (DMA) (Reciever) |
| SERIAL 2 | RX3/TX3 | USART 3 | (NODMA) (ESC) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is Telem unless you change hwdef and make default ESC Telem....which I suggest you do

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is pinned out as ESC telem on the ESC connector, I think not making the protocol ESC telem is a mistake

libraries/AP_HAL_ChibiOS/hwdef/BrahmaF4/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BrahmaF4/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BrahmaF4/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BrahmaF4/defaults.parm Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/BrahmaF4/defaults.parm Outdated Show resolved Hide resolved
Copy link
Author

@ShadowWalker8642 ShadowWalker8642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all done as requested

libraries/AP_HAL_ChibiOS/hwdef/BrahmaF4/defaults.parm Outdated Show resolved Hide resolved
| :------- | :------- | :------ | :------------------ |
| SERIAL 0 | DM/DP | USB | Mavlink |
| SERIAL 1 | RX1/TX1 | USART 1 | (DMA) (Reciever) |
| SERIAL 2 | RX3/TX3 | USART 3 | (NODMA) (ESC) |
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Author

@ShadowWalker8642 ShadowWalker8642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@Hwurzburg
Copy link
Collaborator

I still have an issue about esc telem

@Hwurzburg Hwurzburg added the WIP label Sep 10, 2024
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not understand my request re ESC telem
also need to squash and library split, but I can do that for you if you wish once the last changes are made

libraries/AP_HAL_ChibiOS/hwdef/BrahmaF4/hwdef.dat Outdated Show resolved Hide resolved
@Hwurzburg
Copy link
Collaborator

@ShadowWalker8642 are you still interested in pursuing this? still needs comment addressed and conflicts resolved...

Esc telemetry default

Co-authored-by: Henry Wurzburg <[email protected]>
@ShadowWalker8642
Copy link
Author

@ShadowWalker8642 are you still interested in pursuing this? still needs comment addressed and conflicts resolved...

Hi really sorry been caught up, I have done the esc telemetry change as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants