Copter: guided: set_angle
call init_z_controller
when changing from thrust to climb rate control to avoid flow of control error
#28129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We init the Z controller when we fist enter the angle sub mode of guided. However if you send throttle commands the Z controller is not used, if you then change to sending climb rate commands while remaining in angle sub mode you trigger this flow of control error in the pos controller:
ardupilot/libraries/AC_AttitudeControl/AC_PosControl.cpp
Lines 961 to 969 in a9ea760
extract from #28110