-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_DDS: Status Message #28337
AP_DDS: Status Message #28337
Conversation
Clean commits before merge. |
31ca9c3
to
25bed36
Compare
3a5f232
to
54d5b9e
Compare
54d5b9e
to
4b1a421
Compare
2551865
to
87988d6
Compare
7f360c5
to
9e1217f
Compare
9e1217f
to
a007ff1
Compare
bool flying # True if flying/driving/diving/tracking. | ||
bool external_control # True is external control is enabled. | ||
|
||
uint8 FS_RADIO = 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's supposed to match something, mind adding a comment?
msg.external_control = true; // Always true for now. To be filled after PR#28429. | ||
uint8_t fs_iter = 0; | ||
msg.failsafe_size = 0; | ||
if (AP_Notify::flags.failsafe_radio) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add another comment that "TODO move from AP_Notify to vehicle functions"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
virtual bool in_rc_failsafe() const { return true; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the radio failsafe using this call to RC_Channel rather than AP_Notify:
ardupilot/libraries/RC_Channel/RC_Channel.h
Line 517 in 9f29606
virtual bool in_rc_failsafe() const { return true; }; |
The devs do not want us using notify unless there is no other option.
/ap/status
messageexternal_control
, which will be filled by or after AP_DDS: External Control enable #28429.Test
armed
flag changes.Test a failsafe:
BATT_LOW_VOLT
to 11.0SIM_BATT_VOLTAGE
to 10.6.SIM_RC_FAIL
to 1.