Fix MAV_CMD_DO_JUMP skipping to end of mission when Jump points to itself #28604
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshanne
changed the title
rmackay9
reviewed
Nov 13, 2024
joshanne
force-pushed
the
pr/fix-MAV_CMD_DO_JUMP-skipping-to-end-of-mission
branch
from
35b329c
to
af263c3
Compare
joshanne
force-pushed
the
pr/fix-MAV_CMD_DO_JUMP-skipping-to-end-of-mission
branch
from
af263c3
to
e2c4e84
Compare
Fixes the case where MAV_CMD_DO_JUMP pointing to itself will skip the rest of the mission. This fixes the failure that results from the autotest added in previous commit.
joshanne
force-pushed
the
pr/fix-MAV_CMD_DO_JUMP-skipping-to-end-of-mission
branch
from
e2c4e84
to
87c6372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where a unlimited jump is used, if the jump item points to itself, it will result in the AV skipping the rest of the mission and triggering RTL.
This handles JUMPs that point to themselves by skipping them.
First commit shows the issue occuring, second commit shows the fix to the issue.