Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quadplane-parameters.rst SCHED_LOOP_RATE #5387

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

timtuxworth
Copy link
Contributor

It seems that 400 should be the recommended SCHED_LOOP_RATE fora aquaplane. If anyone knows more about this please add details.

@timtuxworth
Copy link
Contributor Author

Perhaps the parameter documentation for SCHED_LOOP_RATE needs updating too?

@Hwurzburg Hwurzburg requested a review from tridge September 4, 2023 20:41
@Hwurzburg
Copy link
Contributor

@tridge needs to weigh in on this

@tridge
Copy link
Contributor

tridge commented Sep 5, 2023

no, most quadplanes do not need 400. Some very small ones might benefit. The larger the vehicle the less a high loop rate matters, plus the inertia of quadplanes makes their control bandwidth lower so need lower loop rate.
Raising to 400 just leads to larger log files

@timtuxworth
Copy link
Contributor Author

no, most quadplanes do not need 400. Some very small ones might benefit. The larger the vehicle the less a high loop rate matters, plus the inertia of quadplanes makes their control bandwidth lower so need lower loop rate.
Raising to 400 just leads to larger log files

Would it make sense to say this on the wiki page?

@peterbarker
Copy link
Contributor

no, most quadplanes do not need 400. Some very small ones might benefit. The larger the vehicle the less a high loop rate matters, plus the inertia of quadplanes makes their control bandwidth lower so need lower loop rate.
Raising to 400 just leads to larger log files

Would it make sense to say this on the wiki page?

I think it would - this isn't the first time it's come up. Care to put together a PR?

@timtuxworth
Copy link
Contributor Author

no, most quadplanes do not need 400. Some very small ones might benefit. The larger the vehicle the less a high loop rate matters, plus the inertia of quadplanes makes their control bandwidth lower so need lower loop rate.
Raising to 400 just leads to larger log files

Would it make sense to say this on the wiki page?

I think it would - this isn't the first time it's come up. Care to put together a PR?

I've updated this PR based on @tridge 's comment above. Will that do, or are you thinking of something more?

@Hwurzburg
Copy link
Contributor

LGTM...will merge once squashed...thanks

@Hwurzburg
Copy link
Contributor

a little editing....squashed...merging...thanks

@Hwurzburg Hwurzburg merged commit df26e41 into ArduPilot:master Sep 21, 2023
4 checks passed
@timtuxworth timtuxworth deleted the patch-16 branch September 21, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants