-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nvidia_TX1: add ros install scripts #18
base: master
Are you sure you want to change the base?
Conversation
|
||
# install ros | ||
sudo apt-get install -y ros-kinetic-ros-base python-rosinstall ros-kinetic-mavros ros-kinetic-rtabmap-ros ros-kinetic-robot-state-publisher | ||
sudo c_rehash /etc/ssl/certs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that really needed? (maybe tx1 specific ?)
# create workspace | ||
# Note: this seems to fail because some ROS variables are not being set | ||
cd ~/catkin_zed/src | ||
/opt/ros/kinetic/bin/catkin_init_workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't really need normally, the first call of catkin_make will init the workspace
|
||
# kill src directory and build again | ||
rm -rf ~/catkin_zed/src | ||
mkdir -p ~/catkin_zed/src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this look strange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's strange that we need to do the make twice but the first time around the make always fails. I have no idea why at this moment and neither does Dan Pollock..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can understand that catkin_make failed due to missing dependencies, or non-generated msg before need, remove the src shouldn't make a difference !
I don't have the hardware to test ... so I will thrust you on that. I make only general comments ! ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I turned that into Stereolabs. They said they would fix in the next release. Its something in either the build or devel directories that get built the first time through. If you save those off from a good build and add them to a new workspace before you try and build it the build will succeed first time through.
cd ~/catkin_zed/src | ||
/opt/ros/kinetic/bin/catkin_init_workspace | ||
cd ~/catkin_zed | ||
/opt/ros/kinetic/bin/catkin_make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally, catkin_make should be accessible directly since the setup.bash has been sourced
popd | ||
|
||
# cp zed_rtabmap_launch file to /opt/ros/kinetic/share/rtabmap_ros/launch | ||
sudo cp ./zed_rtabmap.launch /opt/ros/kinetic/share/rtabmap_ros/launch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roscp rtabmap_ros rtabmap.launch ./zed_rtabmap.launch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haa understand! you are on the otherside ... well in fact you don't need to be in a workspace to call a .launch . Just roslaunch PATH_TO_FILE/zed_rtabmap.launch will work!
# cd to /opt/ros/kinetic/share/rtabmap_ros/launch | ||
# sudo cp /opt/ros/kinetic/share/rtabmap_ros/launch/rtabmap.launch /opt/ros/kinetic/share/rtabmap_ros/launch/zed_rtabmap.launch | ||
# sudo vi /opt/ros/kinetic/share/rtabmap_ros/launch/zed_rtabmap.launch | ||
# replace "/camera/rgb" with "/camera/zed/rgb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this step is missing ! something like maybe
sed -i -e "s/rgb/zed/rgb/g" ./zed_rtabmap.launch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this is not needed
On Mon, 6 Feb 2017, khancyr wrote:
sed -i -e "s/rgb/zed/rgb/g" ./zed_rtabmap.launch
I think you mispelt "perl".
|
@peterbarker I noob so much at this (point click kid here ^^) ! So I will watch and learn if you got another solution |
About the launch, explicite use roslaunch isn't needed as the first .launch called will bring roscore up. I would recommand the use of a master roslaunch that launch everything needed and https://github.com/clearpathrobotics/robot_upstart to create clean auto launcher for ROS stuff ! |
I initially use robot_upstart, but then write my own upstart job: https://github.com/vooon/rarog/blob/master/rarog_configs/rpi2/rarog.conf Several run of roslaunch can be replaced with one bringup: https://github.com/vooon/rarog/blob/master/rarog_bringup/launch/robot_bringup.launch E.g. something like that: <launch>
<group ns="camera">
<include file="$(find zed_wrapper)/launch/zed.launch" />
<!-- node for static tf. but better to use urdf + robot_state_publisher -->
<include file="$(find rtabmap_ros)/launch/zed_rtabmap.launch">
<arg name="rtabmap_args" value="--delete_db_on_start" />
<arg name="depth_topic" value="/camera/zed/depth/depth_registered" />
</include>
</group>
<!-- other nodes, not in /camera -->
</launch> |
@vooon thanks for the inputs !! |
@khancyr my opinion, that upstart has better config (DSL, easier to understand), but other is common in both systems. And now major distros are use systemd anyway. |
This PR does the following: