-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XT-2384: Use pyproject.toml to define PyPI package #460
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can drop Python 3.7 support, but otherwise looks good
QA +10 Unit and Skynet tests pass successfully. Builds successfully. @Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Reason for change
We want to publish ixbrl-viewer to PyPI and pyproject.toml is the modern way of defining packages in Python.
Closes #448
Description of change
Deleted
setup.py
,requirements.txt
,requirements-dev.txt
Created
pyproject.toml
Changed the
pip
install in workflows and Dockerfile to usepyproject.toml
Updated versioning to use
setuptools
Updated Dockerfile python build to use
build
Steps to Test
CI
review:
@Workiva/xt
@paulwarren-wk