Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XT-2384: Use pyproject.toml to define PyPI package #460

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

aaroncameron-wk
Copy link
Contributor

@aaroncameron-wk aaroncameron-wk commented Jun 22, 2023

Reason for change

We want to publish ixbrl-viewer to PyPI and pyproject.toml is the modern way of defining packages in Python.
Closes #448

Description of change

Deleted setup.py, requirements.txt, requirements-dev.txt
Created pyproject.toml
Changed the pip install in workflows and Dockerfile to use pyproject.toml
Updated versioning to use setuptools
Updated Dockerfile python build to use build

Steps to Test

CI

review:
@Workiva/xt
@paulwarren-wk

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@austinmatherne-wk austinmatherne-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop Python 3.7 support, but otherwise looks good

@derekgengenbacher-wf
Copy link
Contributor

QA +10 Unit and Skynet tests pass successfully. Builds successfully.

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 0b03bd1 into Arelle:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pyproject.toml to define PyPI package
6 participants