Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional test for calling getScaleLabel on facts with no units. #476

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

paulwarren-wk
Copy link
Contributor

@paulwarren-wk paulwarren-wk commented Jun 29, 2023

Reason for change

Additional tests for the fix on #446 that more closely reflect what caused #435. The underlying issue on #435 was calling getScaleLabel on a fact with absent units, rather than null units.

getScaleLabel was previously tested via readableAccuracy which has its own guard for non-numeric facts, but it's also called directly from getUsedScaleMap on anything with a scale attribute.

Description of change

Additional tests that call getScaleLabel with missing units.

Closes #435 .

Steps to Test

review:
@Workiva/xt
@paulwarren-wk

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@austinmatherne-wk
Copy link
Contributor

Verified

  • ci

QA +10
@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit c5dee7a into Arelle:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] getUsedScalesMap fails on reports with missing taxonomy definitions
6 participants