Additional test for calling getScaleLabel on facts with no units. #476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Additional tests for the fix on #446 that more closely reflect what caused #435. The underlying issue on #435 was calling
getScaleLabel
on a fact with absent units, rather thannull
units.getScaleLabel
was previously tested viareadableAccuracy
which has its own guard for non-numeric facts, but it's also called directly fromgetUsedScaleMap
on anything with ascale
attribute.Description of change
Additional tests that call
getScaleLabel
with missing units.Closes #435 .
Steps to Test
review:
@Workiva/xt
@paulwarren-wk