Support for Calculation 1.1 relationships #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
brettkail-wk
previously approved these changes
May 30, 2024
paulwarren-wk
force-pushed
the
calculation-1.1-relationships
branch
from
65af4b2
to
3f1543f
Compare
austinmatherne-wk
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Although we already have a mode for applying Calc 1.1 semantics to legacy calculation relationships, reports using Calculation 1.1 relationships in the taxonomy did not show any calculation relationships in the viewer.
Description of change
Calculations 1.1 relationships are now included in the JSON taxonomy data. The viewer will now show calculations defined using either relationship type, but if a total has both types in a single ELR, Calc 1.1 takes precedence.
Steps to Test
Prepare a report using the Calc 1.1 summation-item relationship, and confirm that calculations are shown in the viewer. Example below is a filing that has been modified to use the the new arcrole:
wk-calc11.zip
review:
@Arelle/arelle
@paulwarren-wk