Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(world-cli): Add commands for running evm and da layer #17

Conversation

jerargus
Copy link
Contributor

@jerargus jerargus commented Nov 29, 2023

Closes: #WORLD-505

What is the purpose of the change

Add commands to start and stop evm and da layer containers.

To start the evm for prod (this will fail to start if some config variables are missing):

world evm start

To start evm in dev mode (A da layer container will be started and appropriate env variables will be injected into the config)

world evm start --dev

To stop the evm and da layers:

world evm stop

Testing and Verifying

I ran manual tests locally after cloning the starter game template.

The current state of starter-game-template has an incorrect negative block time. It's fixed with this PR: Argus-Labs/starter-game-template#32

@jerargus jerargus marked this pull request as ready for review November 29, 2023 21:36
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9ec5c4b) 57.14% compared to head (66106fd) 61.29%.

Files Patch % Lines
common/config/config.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   57.14%   61.29%   +4.14%     
==========================================
  Files           4        4              
  Lines         105      124      +19     
==========================================
+ Hits           60       76      +16     
- Misses         43       45       +2     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/world/evm/evm.go Outdated Show resolved Hide resolved
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally

@jerargus jerargus merged commit e2696f7 into main Dec 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants