Add compatibility with FNA #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ureAtlas.cs changed to use the Rectangle constructor with four parameters.
…st surprising way of adding Monogame.Aseprite to a FNA project
AristurtleDev
requested changes
Apr 3, 2024
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- Project level package properties --> |
There was a problem hiding this comment.
Since FNA isn't distributed via NuGet and this csproj wouldn't be included in the package building done by the cake script, this entire PropertyGroup can be removed.
| </PropertyGroup> | ||
|
|
||
| <!-- Includes for NuGets --> | ||
| <ItemGroup> |
There was a problem hiding this comment.
Same as above, this Item group can be removed since this csproj wouldn't be packed for NuGet
There was a problem hiding this comment.
removed the stuff in the next commit
… to NuGet package stuff
AristurtleDev
approved these changes
Apr 3, 2024
|
Thansk @nobledemon |
gameoflord012
added a commit
to gameoflord012/monogame-aseprite
that referenced
this pull request
Apr 20, 2024
This reverts commit cd33df6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I did a single line change on TextureAtlas.cs. This is due to the fact that FNA doesn't support as many Rectangle constructors as Monogame does.
I also consulted very briefly on the FNA discord with some people to check what would be the least surprising way to provide support for FNA. As a result, I am proposing the addition of a new project file that expects the library folder to stay next to the FNA and AsepriteDotNet dependencies.
I also manually tested the examples in the regular monogame solution, to check that nothing was broken with this change.