Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: chart component updates #597

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Conversation

alexbarnsley
Copy link
Member

Summary

https://app.clickup.com/t/862kebkg6

required by ArdentHQ/arkscan#561

There doesn't seem to be any usage of the chart component / CustomChart JS outside of explorer. I tried to modify in a way that wouldn't cause breaking changes

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley alexbarnsley changed the title refactor: chart component refactor: chart component updates Sep 28, 2023
@ItsANameToo ItsANameToo merged commit 8d05795 into main Oct 2, 2023
6 checks passed
@ItsANameToo ItsANameToo deleted the refactor/chart-component branch October 2, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants