-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update schnorr implementation #129
refactor: update schnorr implementation #129
Conversation
…ate-schnorr-implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still a couple things to adjust on this PR:
- identity fixture should use keccak address format + update WIF
- builder tests are failing on serialisation
- some remaining deserialiser tests
public key has an issue where it shows only 32 bytes instead of the 33 needed. Has to do with the |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feat/mainsail #129 +/- ##
================================================
Coverage ? 67.00%
================================================
Files ? 54
Lines ? 1000
Branches ? 105
================================================
Hits ? 670
Misses ? 302
Partials ? 28 ☔ View full report in Codecov by Sentry. |
Summary
https://app.clickup.com/t/86du3ct7y
Checklist