Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update schnorr implementation #129

Merged
merged 33 commits into from
Jul 29, 2024

Conversation

alexbarnsley
Copy link
Member

Summary

https://app.clickup.com/t/86du3ct7y

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link
Member

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a couple things to adjust on this PR:

  • identity fixture should use keccak address format + update WIF
  • builder tests are failing on serialisation
  • some remaining deserialiser tests

@ItsANameToo
Copy link
Member

public key has an issue where it shows only 32 bytes instead of the 33 needed. Has to do with the PublicKeyXOnly implementation used

@ItsANameToo ItsANameToo changed the title [wip] refactor: update schnorr implementation refactor: update schnorr implementation Jul 26, 2024
@ItsANameToo ItsANameToo marked this pull request as ready for review July 26, 2024 15:54
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.12871% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/mainsail@25c6867). Learn more about missing BASE report.

Files Patch % Lines
crypto/utils/message.py 78.26% 2 Missing and 3 partials ⚠️
crypto/identity/private_key.py 0.00% 3 Missing ⚠️
crypto/transactions/deserializers/vote.py 66.66% 2 Missing and 1 partial ⚠️
crypto/transactions/serializers/multi_payment.py 75.00% 0 Missing and 1 partial ⚠️
crypto/transactions/serializers/transfer.py 75.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##             feat/mainsail     #129   +/-   ##
================================================
  Coverage                 ?   67.00%           
================================================
  Files                    ?       54           
  Lines                    ?     1000           
  Branches                 ?      105           
================================================
  Hits                     ?      670           
  Misses                   ?      302           
  Partials                 ?       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ItsANameToo ItsANameToo merged commit 670c967 into feat/mainsail Jul 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants