Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove old transaction types #131

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

alexbarnsley
Copy link
Member

Summary

https://app.clickup.com/t/86du506a0

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feat/mainsail@670c967). Learn more about missing BASE report.

Files Patch % Lines
crypto/transactions/builder/base.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##             feat/mainsail     #131   +/-   ##
================================================
  Coverage                 ?   81.60%           
================================================
  Files                    ?       39           
  Lines                    ?      810           
  Branches                 ?       97           
================================================
  Hits                     ?      661           
  Misses                   ?      121           
  Partials                 ?       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ItsANameToo ItsANameToo merged commit a4ef9ce into feat/mainsail Jul 29, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the refactor/remove-old-transaction-types branch July 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants