Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Ranking #88

Merged
merged 6 commits into from
Apr 5, 2024
Merged

New Ranking #88

merged 6 commits into from
Apr 5, 2024

Conversation

adriiglz
Copy link
Contributor

@adriiglz adriiglz commented Apr 5, 2024 •
edited
Loading

Modified the user schema to extend info about the played games.

Then, refactored Ranking functionallity for displaying this new info.

  • Backend was modified to retrieve this data
  • Frontend as well to display it

@adriiglz adriiglz added the Enhancement ✴️ New feature or request label Apr 5, 2024
@adriiglz adriiglz added this to the Prototype 1.0 milestone Apr 5, 2024
ChristianFN2
ChristianFN2 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@ChristianFN2 ChristianFN2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Now we have to integrate the scoring system to make use of this ranking.

@ChristianFN2 ChristianFN2 merged commit a794bea into develop Apr 5, 2024
1 check failed
@adriiglz adriiglz mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianFN2 ChristianFN2 ChristianFN2 approved these changes

@andrrsin andrrsin Awaiting requested review from andrrsin

@uo287841 uo287841 Awaiting requested review from uo287841

Assignees

@ChristianFN2 ChristianFN2

Labels
Enhancement ✴️ New feature or request
Projects
None yet
Milestone
Prototype 1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adriiglz @ChristianFN2