object_store: refactor direct multipart methods, implement for GCP. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
requested changes
Sep 5, 2023
object_store/src/gcp/mod.rs
Outdated
| Ok(inner | ||
| .put_multipart_part(bytes.to_vec(), part_number) | ||
| .await | ||
| .unwrap()) |
There was a problem hiding this comment.
I don't think we want to unwrap here (or anywhere in this code) on errors as that will panic our code (which expects, at least in the controller, to be able to handle errors).
Generally you would handle this by wrapping the IO error in the crate error type. For example, there's a Error::Generic type that can handle any kind of error.
There was a problem hiding this comment.
Ah, figured it out. The Error in the gcp context is GCP specific and I was having a hard time constructing it. The crate's Error does the trick.
jacksonrnewhouse
force-pushed
the
multipart_gcp
branch
from
f1fbc30
to
4ff6ce2
Compare
mwylde
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of the multipart additions to ObjectStore, implement for GCP.