Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui/eslint): update eslint-plugin-artalk to v1.0.2 #1010

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

qwqcode
Copy link
Member

@qwqcode qwqcode commented Oct 18, 2024

  • Add new ESLint rules for ArtalkPlugin:
    • Available rules: noCycleDeps, noLifeCycleEventInNestedBlocks, noEventInWatchConf, noInjectInNestedBlocks, noInjectOutsidePlugin, onePluginPerFile. For more details, see eslint-plugin-artalk.
  • Add tests for the new ESLint rules.
  • Implement Tarjan's algorithm for detecting SCCs in the noCycleDeps rule.
  • Improve code organization and maintainability.
  • Disable the 'import-x/namespace' rule for better performance. (import/namespace is very slow import-js/eslint-plugin-import#2340)

- Add new ESLint rules for ArtalkPlugin:
  - Available rules: `noCycleDeps`, `noLifeCycleEventInNestedBlocks`, `noEventInWatchConf`, `noInjectInNestedBlocks`, `noInjectOutsidePlugin`, `onePluginPerFile`. For more details, see [eslint-plugin-artalk](https://github.com/ArtalkJS/Artalk/tree/master/ui/eslint-plugin-artalk).
- Add tests for the new ESLint rules.
- Implement Tarjan's algorithm for detecting SCCs in the `noCycleDeps` rule.
- Improve code organization and maintainability.
- Disable the 'import-x/namespace' rule for better performance. (import-js/eslint-plugin-import#2340)
@qwqcode qwqcode merged commit f6c99e9 into master Oct 18, 2024
11 checks passed
@qwqcode qwqcode deleted the feat/eslint branch October 18, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant