feat(ui): bump deps #679
Merged
feat(ui): bump deps #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我尝试在 Windows 环境下编译无法通过，有一个来自 之前的解决方法是降级到 我看到它 v3.0.0 的新版 Release notes：use get-tsconfig to replace tsconfig-paths (78a08e0) 可能换了 https://github.com/privatenumber/get-tsconfig 的 eslint-import-resolver-typescript 在 win 环境下有 bug。 暂时还没明确具体原因。但是降级到 2.7.0 就能跑了。
不知道是不是我配置的问题：https://github.com/ArtalkJS/Artalk/blob/master/ui/.eslintrc.js#L38-L47 可以帮忙看看吗，谢谢！ |
|
fixes #674 |
Mister-Hope
commented
Dec 18, 2023
ui/packages/artalk/package.json
Outdated
| @@ -3,6 +3,7 @@ | |||
| "version": "2.7.1", | |||
| "license": "MIT", | |||
| "description": "A Selfhosted Comment System", | |||
| "type": "module", | |||
There was a problem hiding this comment.
No, this will introduce new issues in esm strict env, see my new opened discussion, a in time discussion would help.
Mister-Hope
commented
Dec 18, 2023
Comment on lines
+27
to
+35
| "./dist/*": "./dist/*", | ||
| "./dist/Artalk": "./dist/Artalk.js", | ||
| "./dist/Artalk.es": "./dist/Artalk.es.js", | ||
| "./dist/Artalk.iife": "./dist/Artalk.iife.js", | ||
| "./dist/ArtalkLite": "./dist/ArtalkLite.js", | ||
| "./dist/ArtalkLite.es": "./dist/ArtalkLite.es.js", | ||
| "./dist/ArtalkLite.iife": "./dist/ArtalkLite.iife.js", | ||
| "./dist/i18n/jp": "./dist/i18n/jp.js", | ||
| "./dist/i18n/zh-TW": "./dist/i18n/zh-TW.js", |
There was a problem hiding this comment.
These should be removed in v3, ref in #690
|
cc @qwqcode |
Closed
qwqcode
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use marked@v11, could be a possible breaking change