Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add site_url config option #967

Merged
merged 2 commits into from
Sep 3, 2024
Merged

feat(config): add site_url config option #967

merged 2 commits into from
Sep 3, 2024

Conversation

qwqcode
Copy link
Member

@qwqcode qwqcode commented Sep 3, 2024

Add an ATK_SITE_URL environment variable and configuration option to allow modification of the default site URL, optimizing the deployment process experience.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 31.29%. Comparing base (d2225d5) to head (4c734b7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/conf_sync.go 25.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
- Coverage   31.40%   31.29%   -0.11%     
==========================================
  Files         205      205              
  Lines        8776     8780       +4     
==========================================
- Hits         2756     2748       -8     
- Misses       5868     5877       +9     
- Partials      152      155       +3     
Flag Coverage Δ
go 31.29% <40.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwqcode qwqcode merged commit 9cc9a6d into master Sep 3, 2024
7 of 8 checks passed
@qwqcode qwqcode deleted the feat/config branch September 3, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant