feat(plugin/page_vote): add page_vote plugin
#983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjust code structure disable `page vote` plugin by default
Liumingxun
commented
Sep 22, 2024
|
|
||
| function initPageVoteWidget(ctx: ContextApi, options: PageVoteOptions) { | ||
| const btnContainer = document.querySelector<HTMLElement>(options.btnEl) | ||
| if (!btnContainer) return // throw Error(`page vote's config \`btnEl\` selector ${options.btnEl} not found`) |
There was a problem hiding this comment.
to avoid test failed, it skips when enable page vote but there is no element to render, is this ok?
ui/artalk/src/style/_action-btn.scss
Outdated
There was a problem hiding this comment.
extract this style for reuse
I think it can be further optimized, all of div.atk-actions span.atk-common-action-btn have duplicate style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the "vote up/down page" button should be appended to a specified element. Style and update vote count still have some problem, but it's a work in progress.
Feel free to discuss with me and share your thoughts.
close #944