Standard library header <codecvt> is removed in C++17 #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 77755a1)
Here it gets replaced with Windows equivalent. Code for replacement function is found on https://stackoverflow.com/questions/42946335/deprecated-header-codecvt-replacement
This was referenced Mar 29, 2024
|
This PR also closes #292 issue. |
shleym2000
commented
Apr 13, 2024
opennn/loss_index.cpp
Outdated
| @@ -1039,7 +1039,7 @@ Tensor<type, 1> LossIndex::calculate_numerical_gradient() | |||
|
|
|||
| for(Index i = 0; i < parameters_number; i++) | |||
| { | |||
| h = 0.01; // calculate_h(parameters(i)); | |||
| h = static_cast<type>(0.01); // calculate_h(parameters(i)); | |||
There was a problem hiding this comment.
Prevents from warning about conversion from double to opennn::type
shleym2000
commented
Apr 13, 2024
| @@ -9,7 +9,9 @@ | |||
|
|
|||
| #define EIGEN_PERMANENTLY_DISABLE_STUPID_WARNINGS | |||
|
|
|||
| #define _CRT_SECURE_NO_WARNINGS | |||
| #ifndef _CRT_SECURE_NO_WARNINGS | |||
There was a problem hiding this comment.
Prevents from warnings about duplicate _CRT_SECURE_NO_WARNINGS definitions for almost every file being compiled
# Conflicts: # opennn/loss_index.cpp
# Conflicts: # opennn/data_set.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would allow OpenNN to continue evolving into higher C++ standards.
Here it gets replaced with Windows equivalent. Code for replacement function is found on https://stackoverflow.com/questions/42946335/deprecated-header-codecvt-replacement