Preparation to bump the RandomX dataset size to 4096MiB #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldmberman
force-pushed
the
feature/packing-difficulty
branch
from
7fb7006
to
2710c1f
Compare
JamesPiechota
force-pushed
the
jp/randomx-dataset-20240826
branch
2 times, most recently
from
bb1a851
to
ff6dd4c
Compare
JamesPiechota
changed the title
ldmberman
reviewed
Sep 5, 2024
| @@ -1,6 +1,6 @@ | |||
| -module(ar_randomx_state). | |||
|
|
|||
| -export([init/2, init/4, start/0, start_block_polling/0, reset/0, hash/2, | |||
| -export([init/2, init/4, start/0, start_block_polling/0, reset/0, | |||
There was a problem hiding this comment.
I would remove this module completely because we do not need it any more. The ar_randomx_state:get_key_block query in ar_http_iface_middleware is totally unnecessary and easy to remove too.
There was a problem hiding this comment.
Sounds good! Can I do it in the next PR?
ldmberman
approved these changes
Sep 5, 2024
ldmberman
force-pushed
the
jp/randomx-dataset-20240826
branch
from
8b99f2f
to
168c32d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reencrypt_legacy_compositeNIF since we won't be able to do that across RandomX dataset sizes