Github #2063: Debian installer - set max_input_vars = 5000 #2064
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5000
CentOS installer includes a php file that sets the max_input_vars to 5000 from the default 1000. Debian should also have this setting by default.
To test:
Run aspen installer on Debian as if you were setting up a new Aspen, note that the /etc/php/${php_vers}/apache2/php.ini file has a max_input_vars of 1000
apply this patch, rerun the installer, note that the same file should now have max_input_vars of 5000.
|
please merge with the release notes PR coming just after this :) |
mdnoble73
requested changes
Sep 26, 2024
| @@ -32,6 +32,7 @@ php_ini="/etc/php/${php_vers}/apache2/php.ini" | |||
| grep -q '^memory_limit = 256M' "$php_ini" || sed -Ei 's/^memory_limit = [0-9]+M/memory_limit = 256M/' "$php_ini" | |||
| grep -q '^post_max_size = 75M' "$php_ini" || sed -Ei 's/^post_max_size = [0-9]+M/post_max_size = 75M/' "$php_ini" | |||
| grep -q '^upload_max_filesize = 75M' "$php_ini" || sed -Ei 's/^upload_max_filesize = [0-9]+M/upload_max_filesize = 75M/' "$php_ini" | |||
| grep -q '^;max_input_vars = 1000' "$php_ini" || sed -Ei 's/^;max_input_vars = [0-9]+/max_input_vars = 5000/' "$php_ini" | |||
There was a problem hiding this comment.
It looks like this is looking for the commented out line, but not uncommenting it which means the new value would not apply. Is that your intention
There was a problem hiding this comment.
This also will not update existing installs. Is that needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS installer includes a php file that sets the max_input_vars to 5000 from the default 1000. Debian should also have this setting by default.
To test:
Run aspen installer on Debian as if you were setting up a new Aspen, note that the /etc/php/${php_vers}/apache2/php.ini file has a max_input_vars of 1000
apply this patch, rerun the installer, note that the same file should now have max_input_vars of 5000.