Emit an error on not implemented closure (#955)

src/compiler.ts

@@ -7251,6 +7251,15 @@ export class Compiler extends DiagnosticEmitter {
     switch (target.kind) {
       case ElementKind.LOCAL: {
         let type = (<Local>target).type;
+        if (target.parent != flow.parentFunction) {
+          // Closures are not yet supported
+          this.error(
+            DiagnosticCode.Not_implemented,
+            expression.range
+          );
+          this.currentType = type;
+          return module.unreachable();
+        }
         assert(type != Type.void);
         if ((<Local>target).is(CommonFlags.INLINED)) {
           return this.compileInlineConstant(<Local>target, contextualType, constraints);

tests/compiler/closure.json

@@ -1,5 +1,9 @@
 {
   "asc_flags": [
     "--runtime none"
+  ],
+  "stderr": [
+    "AS100: Not implemented.",
+    "EOF"
   ]
 }

tests/compiler/closure.ts

@@ -1,16 +1,8 @@
-// TODO
+function test($local0: i32, $local1: i32): (value: i32) => i32 {
+  return function inner(value: i32) {
+    return $local1; // closure
+  };
+}
 
-// export function outer(): () => () => i32 {
-//   var inner: i32 = 42; // should become a global right away
-//   return function a(): () => i32 {
-//     return function b(): i32 {
-//       return inner++;
-//     };
-//   };
-// }
-
-// var fnA = outer();
-// var fnB = fnA();
-
-// assert(fnB() == 42);
-// assert(fnB() == 43);
+test(1, 2);
+ERROR("EOF");