Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix indicator margin for governance item #1412

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix indicator margin for governance item #1412

merged 1 commit into from
Oct 29, 2024

Conversation

gtg7784
Copy link
Member

@gtg7784 gtg7784 commented Oct 29, 2024

Pull Request Summary

Fix Menu indicator, it has wrong margin top because of the governance item

AS_IS
image

TO_BE
image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Fixes

  • FIx desktop indicator

@gtg7784 gtg7784 requested review from bobo-k2, impelcrypto and codespool and removed request for bobo-k2 October 29, 2024 11:35
Copy link

Visit the preview URL for this PR (updated for commit a98a854):

https://astar-apps--pr1412-fix-menu-indicator-7v2umugm.web.app

(expires Tue, 05 Nov 2024 11:45:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@gtg7784 gtg7784 merged commit 0f7a1dc into main Oct 29, 2024
9 checks passed
@gtg7784 gtg7784 deleted the fix-menu-indicator branch October 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants