Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/landing page update #693

Merged
merged 49 commits into from
Sep 23, 2024
Merged

Feature/landing page update #693

merged 49 commits into from
Sep 23, 2024

Conversation

codespool
Copy link
Contributor

@codespool codespool commented Jul 19, 2024

Redesign the landing page according to design: https://www.figma.com/design/iWhh82EIXNR9EVSkc9sHAG/Astar-Docs?node-id=340-21&t=6nixgtL6wnmJAuwj-0

  • customise header and footer
  • implement custom search (swizzle the native algolia docusearch component)
  • implement tab and dropdown menus

After CSS inconsistencies in the prod build:

  • upgrade and lock all dependencies
  • remove sass plugin
  • modify build command so minifier is not breaking css
  • fix case-insensitive links
  • image and styles cleanup
  • additional css updates:
    • consistent background color
    • background image
    • borders and small tweaks

@codespool codespool added the enhancement New feature or request label Jul 19, 2024
Copy link

github-actions bot commented Jul 19, 2024

Visit the preview URL for this PR (updated for commit b11bc43):

https://astar-docs--pr693-feature-landing-page-42u78gzf.web.app

(expires Mon, 30 Sep 2024 09:43:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

@codespool codespool marked this pull request as ready for review July 24, 2024 14:52
@codespool codespool requested review from a team as code owners July 24, 2024 14:52
@Kahonnohak
Copy link
Contributor

Kahonnohak commented Jul 26, 2024

Thanks!!

  1. fix links
  • Banner (homepage), (build & Earn) somehow button is not working.
  • Banner faucet -> https://docs.astar.network/docs/build/environment/faucet
Screenshot 2024-07-26 at 14 48 17 Screenshot 2024-07-26 at 14 35 24 Screenshot 2024-07-26 at 14 34 28
  1. Please remove old design banners

@Kahonnohak
Copy link
Contributor

Kahonnohak commented Jul 26, 2024

  1. Footer (desktop)
  • Please adjust the padding for footer
  • Please remove the background white and don't cut the gradients
Screenshot 2024-07-26 at 14 54 14

@Kahonnohak
Copy link
Contributor

  1. Mobile
  • please make side margin 12px
  • and change the padding inside of the box to 16px
Screenshot 2024-07-26 at 15 05 16

@Kahonnohak
Copy link
Contributor

Kahonnohak commented Jul 26, 2024

  1. mobile modal
  • Please add 12px side margin
  • Please use close icon :
<svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 20 20" fill="none">
<path d="M5 15L15 5M5 5L15 15" stroke="#94A3B8" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round"/>
</svg>
  • Please use open icon :
<svg xmlns="http://www.w3.org/2000/svg" width="20" height="21" viewBox="0 0 20 21" fill="none">
<path fill-rule="evenodd" clip-rule="evenodd" d="M5.29289 7.79289C5.68342 7.40237 6.31658 7.40237 6.7071 7.79289L9.99999 11.0858L13.2929 7.79289C13.6834 7.40237 14.3166 7.40237 14.7071 7.79289C15.0976 8.18342 15.0976 8.81658 14.7071 9.20711L10.7071 13.2071C10.3166 13.5976 9.68341 13.5976 9.29289 13.2071L5.29289 9.20711C4.90237 8.81658 4.90237 8.18342 5.29289 7.79289Z" fill="#020617"/>
</svg>
Screenshot 2024-07-26 at 15 10 55 Screenshot 2024-07-26 at 15 10 46

@Kahonnohak
Copy link
Contributor

@codespool I have some request for a change, I would like to explain on Thursday together with other docs design. thank you!

src/components/HomePage/Search.tsx Outdated Show resolved Hide resolved
@codespool codespool merged commit 25be04b into main Sep 23, 2024
2 checks passed
@codespool codespool deleted the feature/landing-page-update branch September 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants